Draft
Conversation
Courtney3141
force-pushed
the
split_serial_rx_tx_clients
branch
from
b9d9794 to
594fd86
Compare
… is passed Signed-off-by: Courtney Darville <courtneydarville94@outlook.com>
Signed-off-by: Courtney Darville <courtneydarville94@outlook.com>
Courtney3141
force-pushed
the
split_serial_rx_tx_clients
branch
from
594fd86 to
196f206
Compare
JE-Archer
changed the base branch from
main
to
simplify_serial_queue_interface
Courtney3141
force-pushed
the
simplify_serial_queue_interface
branch
3 times, most recently
from
32a4bb8 to
524ca66
Compare
Courtney3141
force-pushed
the
simplify_serial_queue_interface
branch
2 times, most recently
from
41b35a2 to
d8bed51
Compare
Courtney3141
force-pushed
the
simplify_serial_queue_interface
branch
from
d52a7d8 to
bdb9b0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the serial subsystem, it makes sense to have a different number of clients capable of input and output: not all clients which are capable of output will need input. Prior to this PR, there was a
SERIAL_NUM_CLIENTSmacro, as well as aSERIAL_TX_ONLYmacro which indicated whether or not serial input was required (e.g. whether the driver enabled RX IRQs, or if an RX virtualiser is necessary).I believe it makes more sense to instead have a separate count for each functionality, as for example it is plausible that a system may have only 1 client with input enabled, and more than 1 with output enabled.
This PR essentially turns the
SERIAL_NUM_CLIENTSandSERIAL_TX_ONLYmacros into theSERIAL_NUM_TX_CLIENTSandSERIAL_NUM_RX_CLIENTSmacros, in preparation for the tooling supporting specification for each client whether TX and/or RX are enabled.Merge after #301.